Can you give me the easy and understandable implementation of Miller Rabin in C++?
# | User | Rating |
---|---|---|
1 | jiangly | 3640 |
2 | Benq | 3593 |
3 | tourist | 3572 |
4 | orzdevinwang | 3561 |
5 | cnnfls_csy | 3539 |
6 | ecnerwala | 3534 |
7 | Radewoosh | 3532 |
8 | gyh20 | 3447 |
9 | Rebelz | 3409 |
10 | Geothermal | 3408 |
# | User | Contrib. |
---|---|---|
1 | maomao90 | 173 |
2 | adamant | 164 |
3 | awoo | 161 |
4 | TheScrasse | 160 |
5 | nor | 159 |
6 | maroonrk | 156 |
7 | SecondThread | 152 |
8 | pajenegod | 146 |
9 | BledDest | 144 |
10 | Um_nik | 143 |
Name |
---|
https://cp-algorithms.com/algebra/primality_tests.html#toc-tgt-2
but it gives wrong output in some cases. Example: 999999999999999989 its a prime number but the output is its a composite number.
Are you sure? I just tried it, and
MillerRabin(999999999999999989LL)
returnstrue
, indicating that it is probably prime.You must made an error calling the function (maybe you forgot to mark it as a long long number?).
Also, if you want to go safe, just use the deterministic Miller-Rabin code, from the next section.