Can you give me the easy and understandable implementation of Miller Rabin in C++?
# | User | Rating |
---|---|---|
1 | ecnerwala | 3648 |
2 | Benq | 3580 |
3 | orzdevinwang | 3570 |
4 | cnnfls_csy | 3569 |
5 | Geothermal | 3568 |
6 | tourist | 3565 |
7 | maroonrk | 3530 |
8 | Radewoosh | 3520 |
9 | Um_nik | 3481 |
10 | jiangly | 3467 |
# | User | Contrib. |
---|---|---|
1 | maomao90 | 174 |
2 | awoo | 164 |
2 | adamant | 164 |
4 | TheScrasse | 159 |
4 | nor | 159 |
6 | maroonrk | 156 |
7 | -is-this-fft- | 150 |
8 | SecondThread | 147 |
9 | orz | 146 |
10 | pajenegod | 145 |
Name |
---|
https://cp-algorithms.com/algebra/primality_tests.html#toc-tgt-2
but it gives wrong output in some cases. Example: 999999999999999989 its a prime number but the output is its a composite number.
Are you sure? I just tried it, and
MillerRabin(999999999999999989LL)
returnstrue
, indicating that it is probably prime.You must made an error calling the function (maybe you forgot to mark it as a long long number?).
Also, if you want to go safe, just use the deterministic Miller-Rabin code, from the next section.