Robin's blog

By Robin, history, 4 years ago, In English

So I was debugging this code and managed input/outputs in separate files. I ran the same code with same flags in codeblocks and WSL ubuntu 18.04, they gave me two different outputs.

My Code

#include<bits/stdc++.h>

using namespace std;

int main() {
#ifdef ROBIN
    freopen("in", "r", stdin);
    freopen("out", "w", stdout);
#endif // ROBIN
    int t, d = 0;
    cin >> t;
    getchar();
    while (t--) {
        string ss, tt;
        getline(cin, ss);
        getline(cin, tt);
        cout << "SS: " << ss << endl;
        cout << "TT: " << tt << endl;
    }
}

Input

3
Tom Marvolo Riddle
I am Lord Voldemort
I am not Harry Potter
Hi Pretty Roar to man
Harry and Voldemort
Tom and Jerry and Harry

Output (Code::Blocks)

SS: Tom Marvolo Riddle
TT: I am Lord Voldemort
SS: I am not Harry Potter
TT: Hi Pretty Roar to man
SS: Harry and Voldemort
TT: Tom and Jerry and Harry

Output (WSL)

SS: 
TT: Tom Marvolo Riddle
SS: I am Lord Voldemort
TT: I am not Harry Potter
SS: Hi Pretty Roar to man
TT: Harry and Voldemort



I would appreciate it if someone gives me a proper explanation of this. Thanks.
Flags:
-DROBIN
-std=c++14
-O2

  • Vote: I like it
  • +14
  • Vote: I do not like it

»
4 years ago, # |
  Vote: I like it 0 Vote: I do not like it

Auto comment: topic has been updated by Robin (previous revision, new revision, compare).

»
4 years ago, # |
  Vote: I like it 0 Vote: I do not like it

Auto comment: topic has been updated by Robin (previous revision, new revision, compare).

»
4 years ago, # |
Rev. 6   Vote: I like it +16 Vote: I do not like it

Nevermind, got the answer. Posting here if anyone needs to know:

Newlines in windows need 2 bytes, while those in linux generally need 1 byte. Before cin >> t I'm using getchar(), which reads only 1 character -> 1 byte. So my getline() reads the other character and I get an extra line because of that. I can convert the input file (from CR-LF) to use UNIX style file endings (LF), or use an extra getchar(), after cin >> t.
Reference: https://superuser.com/questions/1091980/why-are-windows-line-breaks-larger-than-unix-line-breaks

Thanks to https://web.facebook.com/oneshadab for the idea.

  • »
    »
    4 years ago, # ^ |
      Vote: I like it +17 Vote: I do not like it

    Yep. That's why you want to use getline() instead of getchar() whenever you're reading files split into lines — it handles the endline characters correctly automatically.