### bobbilyking's blog

By bobbilyking, history, 3 years ago,

https://pastebin.com/zV3jsqy7

i did look at the CF editorial, and yeah my implementation (i don't think) is wrong. and someone else had the same TLE problem as me but he never said how he resolved it (if he ever did). Is this just a java thing? Editorial says that time complexity is n * target, which is 10^8 operations, so maybe I can make very very slight optimizations somewhere to get it under 1ms?

• 0

| Write comment?
 » 3 years ago, # |   +9 I also got TLE with recursive dp in c++ and had to do iterative. Timelimit is strict but 10^8 is indeed the intended complexity. Try swapping out the modding line with this as mod is a heavy operation.if (whatever >= MOD) whatever -= MOD
•  » » 3 years ago, # ^ |   +3 omg that worked ty
•  » » 3 years ago, # ^ |   +6 Had been scratching my head around what further to optimize....well there's always an optimization ty :)
•  » » 2 years ago, # ^ |   0 woahhh, it really worked!! But I found another code online and it makes the use of MOD but it didn't get any TLE, how is that possible. LINK: https://usaco.guide/problems/cses-1635-coin-combinations-i-unordered/solution
•  » » » 2 years ago, # ^ |   0 I don't remember if that optimization was required in C++ codes for this problem or not. If it was, I have no idea tbh.
•  » » » 2 years ago, # ^ |   +7 Btw one thing to note about this problem. You don't even need $n \cdot x$ mod calls. Here is the solution with n * x mod callsvector dp(x + 1); dp[0] = 1; for (int weight = 1; weight <= x; weight++) { for (int i = 0; i < n; i++) { if(weight - coins[i] >= 0) { dp[weight] += dp[weight - coins[i]]; dp[weight] %= MOD; } } }  Here is the solution with x mod callsvector dp(x + 1); dp[0] = 1; for (int weight = 1; weight <= x; weight++) { for (int i = 0; i < n; i++) { if(weight - coins[i] >= 0) { dp[weight] += dp[weight - coins[i]]; } } dp[weight] %= MOD; } 
•  » » » » 2 years ago, # ^ |   0 Thanks
•  » » 11 months ago, # ^ |   0 It works, thanks.
 » 2 years ago, # | ← Rev. 2 →   +3 Not sure in java but in C++ a%b works slightly faster if b is a constant. So in the following code int mod = 1e9 + 7 will give TLE but int const mod = 1e9 + 7 will not. dp[0] = 1; for (int i = 1; i <= m; i++) { for (int j = 1; j<= n; j++) { int x = i - a[j]; if (x >= 0) dp[i] = (dp[i] + dp[x])%mod; } } cout << dp[m];
•  » » 11 months ago, # ^ |   0 hey! thanks it also worked for me in java
•  » » 9 months ago, # ^ |   0 This saved me in other problem, I was getting TLE with almost the same code I done 2 years before. just adding a const and it got accepted. In Problem "Graph paths I" runs 4 times faster, about 57 million of '%' operations in the worst test case.
•  » » 2 months ago, # ^ |   0 This really works !!! My soln got accepted after 6 attempts :)
•  » » 11 days ago, # ^ |   0 For java user, declare mod globally as: static final int mod = 1000000007; and it will work fine